ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on a change in pull request #155: Simplify single assignment and avoid redundant if conditions.
Date Sat, 25 Sep 2021 11:37:21 GMT

bodewig commented on a change in pull request #155:
URL: https://github.com/apache/ant/pull/155#discussion_r716030510



##########
File path: src/main/org/apache/tools/ant/taskdefs/XmlProperty.java
##########
@@ -404,17 +404,14 @@ public Object processNode(Node node, String prefix, Object container)
{
         }
         String nodeText = null;
         boolean emptyNode = false;
-        boolean semanticEmptyOverride = false;
-        if (node.getNodeType() == Node.ELEMENT_NODE
+        boolean semanticEmptyOverride = node.getNodeType() == Node.ELEMENT_NODE
                 && semanticAttributes
                 && node.hasAttributes()
                 && (node.getAttributes().getNamedItem(VALUE) != null
-                        || node.getAttributes().getNamedItem(LOCATION) != null
-                        || node.getAttributes().getNamedItem(REF_ID) != null
-                        || node.getAttributes().getNamedItem(PATH) != null || node.getAttributes()
-                        .getNamedItem(PATHID) != null)) {
-            semanticEmptyOverride = true;
-        }
+                || node.getAttributes().getNamedItem(LOCATION) != null

Review comment:
       please revert the whitespace change @arturobernalg 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message