ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] basil opened a new pull request #151: Use the correct parent in findResources(String, boolean)
Date Wed, 21 Jul 2021 16:32:00 GMT

basil opened a new pull request #151:
URL: https://github.com/apache/ant/pull/151


   See [#149 (comment)](https://github.com/apache/ant/pull/149#issuecomment-884318912). Amends
`findResources(String, boolean)` to invoke the correct method to get the parent. The `getParent()`
method returns the immutable `parent` field from the parent `ClassLoader` class, which is
not used by `AntClassLoader`. The correct method is `getConfiguredParent()` (introduced in
commit 26f846b83), which returns the mutable `parent` field from the `AntClassLoader` class.
   
   I verified that without this fix, I could reproduce the original problem described by Kohsuke
Kawaguchi in [JENKINS-22310 (comment)](https://issues.jenkins.io/browse/JENKINS-22310?focusedCommentId=197405&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-197405).
I verified that with this fix, I could no longer reproduce the original problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message