ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] basil opened a new pull request #150: Implement `ClassLoader#findResource(String)`
Date Sun, 11 Jul 2021 19:34:59 GMT

basil opened a new pull request #150:
URL: https://github.com/apache/ant/pull/150


   The [Javadoc for `ClassLoader#findResource(String)`](https://docs.oracle.com/javase/8/docs/api/java/lang/ClassLoader.html#findResource-java.lang.String-)
states:
   
   > Class loader implementations should override this method to specify where to find
resources.
   
   `AntClassLoader` doesn't do this. Jenkins needed this back in 2011, so Kohsuke Kawaguchi
(the creator of Jenkins) implemented a workaround in [this Jenkins core commit](https://github.com/jenkinsci/jenkins/commit/601cb6bb43):
   
   ```
   commit 601cb6bb43
   Author: Kohsuke Kawaguchi <kk@kohsuke.org>
   Date:   Mon Oct 10 02:49:45 2011
   
       implement findResource(
   ```
   
   I am now looking into unforking `AntClassLoader` in Jenkins core so that we can reuse the
latest upstream version from Ant 1.10.x. As far as I can tell the fix remains valid and should
be contributed upstream.
   
   This fix is trivial: factoring out the existing implementation used in `getResource` so
that it can also be used to implement `findResource`.
   
   This fix has been battle tested on every Jenkins installation for the past 7 years.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message