ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] basil opened a new pull request #149: Ant doesn't call the superclass constructor and pass in the specified parent classloader
Date Sun, 11 Jul 2021 19:02:07 GMT

basil opened a new pull request #149:
URL: https://github.com/apache/ant/pull/149


   See [JENKINS-21579](https://issues.jenkins.io/browse/JENKINS-21579) and [JENKINS-22310](https://issues.jenkins.io/browse/JENKINS-22310).
Back in 2014, Kohsuke Kawaguchi (the creator of Jenkins) forked `AntClassLoader` from Ant
1.8.3 into Jenkins core to apply [the following fix](https://github.com/jenkinsci/jenkins/commit/9a2882dd70)
to it:
   
   ```
   commit 9a2882dd70 (tag: changes/76)
   Author: Kohsuke Kawaguchi <kk@kohsuke.org>
   Date:   Mon Mar 24 23:04:54 2014
   
       [FIXED JENKINS-21579] UberClassLoader.findResources() improvements
       
       This is just a locally patched version, so not meant to be used outside
       core.
   ```
   
   I am now looking into unforking `AntClassLoader` in Jenkins core so that we can reuse the
latest upstream version from Ant 1.10.x. As far as I can tell the fix remains valid and should
be contributed upstream.
   
   [This comment](https://issues.jenkins.io/browse/JENKINS-22310?focusedCommentId=197405&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-197405)
specifically contains Kohsuke's analysis describing the cause of the problem and the motivation
for the fix.
   
   This fix has been battle tested on every Jenkins installation for the past 7 years.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message