ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] jaikiran commented on pull request #151: findResources(String, boolean) can unnecessarily search the parent
Date Tue, 27 Jul 2021 03:21:23 GMT

jaikiran commented on pull request #151:
URL: https://github.com/apache/ant/pull/151#issuecomment-887177009


   Hello @basil, thank you for your detailed analysis and explanation of your changes. This
looks good to me, plus since Jesse too has had a look at this gives me additional confidence
on these changes. 
   
   As for the tests, it would be good to add new test for this, but given the nature of the
issue that's discussed in the linked Jenkins issue, I can understand that it may not be straightforward.
We do have tests for `AntClassLoader` in our testsuite and I ran the `AntClassLoaderTest`
against JDK 8, 11 and 17 EA on my local setup with these changes and it passed on those versions.
So I think that's good enough to merge this PR.
   
   Thank you for these changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message