ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] jaikiran commented on a change in pull request #149: Ant doesn't call the superclass constructor and pass in the specified parent classloader
Date Wed, 21 Jul 2021 07:50:28 GMT

jaikiran commented on a change in pull request #149:
URL: https://github.com/apache/ant/pull/149#discussion_r673741534



##########
File path: src/main/org/apache/tools/ant/AntClassLoader.java
##########
@@ -297,6 +298,7 @@ public AntClassLoader() {
      *                elements are set up to start with.
      */
     public AntClassLoader(final Project project, final Path classpath) {
+        super(parent);

Review comment:
       I think to make it clear what's being done here, it's better to do `super(null)` instead
of using `parent` which is `null`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message