ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] jaikiran commented on pull request #149: Ant doesn't call the superclass constructor and pass in the specified parent classloader
Date Wed, 21 Jul 2021 07:46:46 GMT

jaikiran commented on pull request #149:
URL: https://github.com/apache/ant/pull/149#issuecomment-883968931


   Hello @basil, although this change looks straightforward and seems to have been in-use
in Jenkins for 7 odd years, I will need some inputs from others before merging this change.
   
   More specifically, I had a look at the `AntClassLoader`'s constructor (the one being changed)
and noticed that it has code that deals with the `parent` in a very specific way. Plus, the
commit history of that class suggests that there was some thought given around how the `parent`
is currently used/set. I don't have that background knowledge, except that it somehow relates
to https://bz.apache.org/bugzilla/show_bug.cgi?id=35436. Perhaps @bodewig or someone more
knowledgeable with this code, might have inputs on whether or not to merge this change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message