From dev-return-92526-apmail-ant-dev-archive=ant.apache.org@ant.apache.org Tue Sep 29 15:31:12 2020 Return-Path: X-Original-To: apmail-ant-dev-archive@www.apache.org Delivered-To: apmail-ant-dev-archive@www.apache.org Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by minotaur.apache.org (Postfix) with ESMTP id E515B190F2 for ; Tue, 29 Sep 2020 15:31:11 +0000 (UTC) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id F01436482D for ; Tue, 29 Sep 2020 15:31:10 +0000 (UTC) Received: (qmail 98269 invoked by uid 500); 29 Sep 2020 15:31:10 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 98231 invoked by uid 500); 29 Sep 2020 15:31:09 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 98214 invoked by uid 99); 29 Sep 2020 15:31:09 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Sep 2020 15:31:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id ACDC5C0104 for ; Tue, 29 Sep 2020 15:31:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: -2.352 X-Spam-Level: X-Spam-Status: No, score=-2.352 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, NICE_REPLY_A=-2.403, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamproc1-he-fi.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([116.203.227.195]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id 5dhC7yBpFo85 for ; Tue, 29 Sep 2020 15:31:08 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.216.54; helo=mail-pj1-f54.google.com; envelope-from=jai.forums2013@gmail.com; receiver= Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id C6DA1BC362 for ; Tue, 29 Sep 2020 15:31:07 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id a9so2864156pjg.1 for ; Tue, 29 Sep 2020 08:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=vmhH4yq+QZN2xd8bZYGKiT6wPil7vKbx5kTDZy2vIIk=; b=lKO8F0qEcllte/O1MWcBUQRHZl18C9xa3lMu8M7tasLGhHmzzP64kxVtOtZy/ozkBA dANjQNWNl41OaWVmmf3pR9LoKefUZkY40NC0G6rHVBRc8xhi+LJmlwZJZ+1SsCfzQ/qN Nce2ZmS9R2IdjHh/0kzViMsrw59uDoqqGZYEM0PJTde2r5mo8EoF8ZmvnowIlwf/Dnqn X9tVqDoQX4GxW2Uzw+kOnq5s8As36IXoSdD5+ApIwub9iWN+QoWva0MR+tHKQrdQjNqx iduBEpxtFcZmhxsRvGZD5uPl88EHV3gKHJKq1WYGmfaEoWfzJ+CrzRgEzfRUp3Qlnqnv Cf5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=vmhH4yq+QZN2xd8bZYGKiT6wPil7vKbx5kTDZy2vIIk=; b=pdGI5aILeelDw2NkTNIXpAniQLLgHzvG0tGt9Klf9j0eaeaPvDvYHFJygYswP/gGLt LnNeAj2OW8zxjHtJjnk1nCf06fDtFehF9DV593Fg5MasWr0AuBzlG6dsDGwYENOBeIti eHycjUx1kzin1CoMtissIpxhPvRMHINwQAbnGKA3aNe/Bk813jJZwFuYNiCiuyV0kmm6 3EASTFnPM+d/R6lv0BF/B4tLZEpSC4RciL0b6Fmk73HzbaLP4IVngnlI7T7zxNB7uoXU /5VhcR4EAHvC6Lw9WJTdYAK0pFkA/8MqTY9uIMncmH8sXAu4Mvwi3eiO2DLjx7gr82dz BlGw== X-Gm-Message-State: AOAM530fbhfv9Dx8SESlxPIY8A7cHYvAPbxkHj/cIW5JzwGRy22a0cRc Kj5RW3pjPOyxbD/N9Cou5GEVrorbrBo= X-Google-Smtp-Source: ABdhPJw5ZwDsxuM3F3r7/2ZFB/ExHUKUJdBBSzzlJtwHAqtmlfX0lQnM0WO0y95t/M0EBtmb4UVf9A== X-Received: by 2002:a17:90b:955:: with SMTP id dw21mr2116198pjb.161.1601393466446; Tue, 29 Sep 2020 08:31:06 -0700 (PDT) Received: from whiteoffice.local ([106.216.160.59]) by smtp.gmail.com with ESMTPSA id i20sm5217743pgk.77.2020.09.29.08.31.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2020 08:31:05 -0700 (PDT) Subject: Re: Now Enabling Nashorn Compatibility To: dev@ant.apache.org References: <877dshr7b5.fsf@v45346.1blu.de> From: Jaikiran Pai Autocrypt: addr=jai.forums2013@gmail.com; keydata= xsFNBFsgsskBEACy8rzosITgdGsfQijFhWkRo/iyXv7LdSD5FezMu6C4UosENKlP85y0XBsE 3Z7K50uxVizyjXTetK+EIS684c6pU1t0vbWyvJzSgHeqf0GEaqiUNWTo9Jk6jAaeYeNu+6/T VUCYrb+zmQqmJPZq5W4FvTnpRed/t4zBPLlFPe2+QNaNRE03JqCrnmih0hrxVcM5jyynXSoz uS50DcMuiOCZL3zPBW6mDGaXH6+yUfFVrReuCB//D0u0sCSiV5TvhSh2+8lLUG5tuvOKfg2S lRFtF9JQIPsm/qV/fK2muW2mc+Ti0n+k3gzxtr4eC5YvShJCe0DoxR9q/CItx6vRg8h+G4Hh L1P5N+Tj4N0zfcUs/2vaJbm3LrjK8o+coNa8dgiIN6AbdcS8szIRYUG2MJzUI1mggYw/i4Yc nNhrKTPZtdbKRfmKAIq1d1eEt/rJ97ypTzeYO6jq6Jkmnb3rWzmx9XA9Mo4J8X7587E6zkiD 3FoFrSaMo20q+byMuXC8kKIEiDOa7UFQUh1ku8RDAmjXlWwqw3+RtrRt0TXoHRNWRoShiBee TjkQ3ZW7FlSk1hs80qeVCcSJ6lf1texmZzonAJCyibEWdzvceGvs2/PenetsnP/5nDlJuEs4 jhoYuU57HjXfcSSOqmLAFAym7pL0Yd+KNhvxjBF/SoJ1wgoLBQARAQABzSVqYWlraXJhbkBh cGFjaGUgPGphaWtpcmFuQGFwYWNoZS5vcmc+wsGrBBMBCAA+FiEEjacMAN968bDS+dx03bzB Jwop0IEFAlsgsskCGwMFCQeGH4AFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AAIQkQ3bzBJwop 0IEWIQSNpwwA33rxsNL53HTdvMEnCinQgQJ0D/45PKFd98bO2g2u8hgX21qY0JVPl3PNj2o6 izqkdKGBfo7fGJzfdQy3c7p5zpFIgsSZzUgmW2GbFVOy7Rcnnv54NgnPMDUlgPVGQtxLr5qq ail+g92nM5+2yFDzIRc8pCXr0iEqfQHrJBz3x3cQdhC26fS31/BADcsagxYftEiwXJwwqLr5 npM5ot2Sk2z2Km4gaSi412p1VMiBAYGYe9DCA7qvqZhKICkTuVDz6z/snWEm4DcbNX2BDwMr 2DSGvUTUSZsb16fGfZdPZXgfiFcUl+sIRiMxOxroRgQ6cDgGrAyYEfHYs4KXJ2E84ltzf/T1 fMBR3BSzFtWAHJnWRS9+jvp4tgLb9he3JWW4vJjBTIYteUFYwKEcz4AhXJODsc1W8UX31zB2 kGCkONQXHrT5+1h8XFcklu7iWrVQso7KqqgPBp5unYL+BndshWapnYYVQKh4i4GH3ilGEQ0r 87QUG5oGneZhoaukNUyCW7Wn2XHPQfa64BSBe7WFEzsZZurlNZQpwP/Nvo0fsM7zZxGoIkSf /+ndapzi0Bm3wHdtAZBZEZDeI5TxHGYO/Kd65XKpZHR0iRvsHKO0PtIpGRKiY2rqjqbD4q6P 7ozR3CFl2Y8Hw79GIsskMovzcNk3o/7IQEixzvepLdA+cK68Q09/GCbQkjZ3rfCddtbhuQ7M 387BTQRbILLJARAArBSYp8IDrZCInCT40Ad9WateCTqWlIITEKMLxG9aC3tHq6kt850oUtEs 1HhrJssX39dxbmuyZ8Xt5OiewDe+cix8se0trMsyhRWCP2NmOW+NzFZfkXylcvsEfTHjjcZm 9k0h0i31II48lQpVl9z1UJy/DnrgTyohsUkFII9UxOJs80tnDk3ci/lZ92pGwiDvSNRGqJI4 wOefVWleJ3RfmJTSu6qWqLmCK53yn/WKwG1VDKIaakOzZSg9pQVTGYhYn+yvE3Hl8DI4p3Za xYAufScm5oiUvQDbnNPMtTdalOQcW+KZYfyiCide2MtB+HvQYng2MGEgCO1AVWm0YY0uV4NV MPUAgw2KZzsbEUZ/gRQCArx9wOsXpa0u0rdCcDeFJccyDOkujU2aKtbLVx+/A3Cex7soJf/5 rGV3WyUCCc1mXdQAOPaKsj+PVuXae2yuITRDU36fvb0bfOWSDRPCP8iM/GjU9brkDtvrY8OE a1qN3B88ozjd0eAnxlgYv/Noq3h6WGxVA8FlxQ6XphX1+D1zmOoAmFQhuF+7JBb78QZidHj/ YbfBsgqJg+y4GJDDic3Uh0ZOl+hb0PKZikhysslmS3b/ip5LFfEdrX+oXsKM6g1XlXNrXv6Y tFLY03v8fP6VzIi5h/t3Msn9T8MjIrhAFwKqbvb0hKwKArYdt3cAEQEAAcLBkwQYAQgAJhYh BI2nDADfevGw0vncdN28wScKKdCBBQJbILLJAhsMBQkHhh+AACEJEN28wScKKdCBFiEEjacM AN968bDS+dx03bzBJwop0IE34g//QtY5NYkyHofCmQ0DhJMFVxIyMA54NH8UqtyAjY8h+fCR srBWzkyMlaKmgz3CFjOfyAGxeA6bl2b2lbtJ7n6VSrqSIi6to0cFwteBvoAvwRLAeylas6KJ /84SpRxKOrFbbpnJBVbY1xvUnwKn96vK0hsGkls0jq4O4Mis54szjwVrNZJCfYfj2o+PLj/R FGCK/rPAVZV0ka+Ewxfvv3az4WdrM7qYUvH69X3nX2gQ/vsTJqRhBhNinp05N6AY7wR7rB7E naKsPCGmdAYXOL2o7qh1hOJ2nLwRmiKebKOZAPjBX+vZfxv/nFo/jz+8bhj8vU5Kil4vAjXU BNYhGulCoQWGgMaUc2roCAw4Up7vVnKGhosaRlQmKI0VtfjpaLphIZe1pIln6t3W9Kv/rqEi RD6pkDO/ou2ev7zyP9zbvjbxbA8oEAPexRdU5dSEsX1oHd2KZUI7kyy8msMVk+3xygq8eE41 DPiT8vsRg3f0T/2JLEnzPXbFfxBK7jdNqgQ6FAA6bocNL5CgvzgMbi5Fg5tIfUt71EN8xoqD DGC72zXvKwD91QuXyex/NLKb/89OSXzu3OIbrVPA9MpENGTblnS+/dhxKHIgt2HVZogsZr7G m3njnjFVNFoBUh4z0anz56EruMrQNEs59nbGeuFVdNQR5t62c8QWUTJkM9wiazM= Message-ID: <369b2356-dea0-fc2d-b276-7c85f22efce9@gmail.com> Date: Tue, 29 Sep 2020 21:01:02 +0530 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <877dshr7b5.fsf@v45346.1blu.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Hello Stefan, I went through these commits and they look fine to me. I think it's OK to set the system property to enable the compatibility. -Jaikiran On 26/09/20 12:51 am, Stefan Bodewig wrote: > Hi all > > things weren't as easy as I had hoped. You cannot enable Nashorn > compatibility via javax.scriptiong bindings, only two options have been > available: > > * set a system property before creating the engine > > * add extra code that depends on Graal and create the ScriptEngine via > Graal's constructor rather than ScriptEngineManager > > I've decided to take the sysproperty approach, even though this means > you cannot revert the decision once you've created your first > engine. This turned out to be challenging for tests as I had to fork the > tests independent of each other. > > I'll cut a release candidate this weekend and start a vote, please vote > with -1 if you feel this apporach is wrong (or speak up before I start > the vote thread if you happen to find the time). > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org > For additional commands, e-mail: dev-help@ant.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org