ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] twogee commented on a change in pull request #115: Remove duplicated code
Date Wed, 29 Jul 2020 07:33:42 GMT

twogee commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r461633282



##########
File path: src/main/org/apache/tools/ant/taskdefs/MacroInstance.java
##########
@@ -221,8 +221,6 @@ private String macroSubs(String s, Map<String, String> macroMapping)
{
             }
         }
         switch (state) {
-            case STATE_NORMAL:
-                break;

Review comment:
       It is explicit now, just as in above case, only merged with default




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message