ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] twogee commented on a change in pull request #115: Remove duplicated code
Date Mon, 27 Jul 2020 10:51:55 GMT

twogee commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r460807226



##########
File path: src/main/org/apache/tools/ant/listener/Log4jListener.java
##########
@@ -142,21 +142,17 @@ public void messageLogged(final BuildEvent event) {
         final Logger log
             = Logger.getLogger(categoryObject.getClass().getName());
         switch (event.getPriority()) {
-            case Project.MSG_ERR:
-                log.error(event.getMessage());
-                break;
             case Project.MSG_WARN:
                 log.warn(event.getMessage());
                 break;
             case Project.MSG_INFO:
                 log.info(event.getMessage());
                 break;
             case Project.MSG_VERBOSE:
-                log.debug(event.getMessage());
-                break;
             case Project.MSG_DEBUG:
                 log.debug(event.getMessage());
                 break;
+            case Project.MSG_ERR:

Review comment:
       It is still explicit...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message