ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code
Date Mon, 27 Jul 2020 10:20:29 GMT

bodewig commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r460791697



##########
File path: src/main/org/apache/tools/bzip2/BlockSort.java
##########
@@ -894,8 +893,8 @@ private void mainQSort3(final CBZip2OutputStream.Data dataShadow,
                     stack_ll[sp] = m;
                     stack_hh[sp] = hi;
                     stack_dd[sp] = d;
-                    sp++;
                 }
+                sp++;

Review comment:
       technically this is redundant code but as `sp` gets incremented several time inside
of the else block I'd prefer to leave the code as it. It makes shape of the code blocks that
assign to the stack arrays the same for all four occasions (the if and three times inside
of the else block).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message