ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code
Date Mon, 27 Jul 2020 10:13:41 GMT

bodewig commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r460788175



##########
File path: src/main/org/apache/tools/ant/taskdefs/optional/jlink/ClassNameReader.java
##########
@@ -56,43 +56,40 @@
             byte type = data.readByte();
             types[i] = type;
             switch (type) {
-            case UTF8 :
-                values[i] = data.readUTF();
-                break;
-
-            case UNUSED :
-                break;
-
-            case INTEGER :
-                values[i] = data.readInt();
-                break;
-
-            case FLOAT :
-                values[i] = data.readFloat();
-                break;
-
-            case LONG :
-                values[i] = data.readLong();
-                ++i;
-                break;
-
-            case DOUBLE :
-                values[i] = data.readDouble();
-                ++i;
-                break;
-
-            case CLASS :
-            case STRING :
-                values[i] = data.readUnsignedShort();
-                break;
-
-            case FIELDREF :
-            case METHODREF :
-            case INTERFACEMETHODREF :
-            case NAMEANDTYPE :
-                values[i] = data.readInt();
-                break;
-            default:
+                case UTF8 :

Review comment:
       why did the indentation change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message