ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on a change in pull request #115: Remove duplicated code
Date Mon, 27 Jul 2020 10:12:20 GMT

bodewig commented on a change in pull request #115:
URL: https://github.com/apache/ant/pull/115#discussion_r460787528



##########
File path: src/main/org/apache/tools/ant/taskdefs/MacroInstance.java
##########
@@ -221,8 +221,6 @@ private String macroSubs(String s, Map<String, String> macroMapping)
{
             }
         }
         switch (state) {
-            case STATE_NORMAL:
-                break;

Review comment:
       To me the explicit case makes it easier to see what happens than having to look up
the default case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message