ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] TonyGravagno opened a new pull request #116: Fix space issue in AntStructure.DTDPrinter
Date Mon, 13 Jan 2020 03:26:33 GMT
TonyGravagno opened a new pull request #116:  Fix space issue in AntStructure.DTDPrinter
URL: https://github.com/apache/ant/pull/116
 
 
   Task AntStructure renders a project DTD. In AntStructure class DTDPrinter, line 327, a
single statement is used to concatenate a list of enumerated values which are valid for an
attribute. The list is enclosed in parentheses. At line 348 the string "#IMPLIED" is appended
to all attribute definitions regardless of type. For other types like Boolean and CDATA, a
space is appended. Not for these enumerations. This results in a DTD validation error. Ref
[XERCES definition](https://xerces.apache.org/xerces-j/apiDocs/org/apache/xerces/utils/XMLMessages.html#MSG_SPACE_REQUIRED_BEFORE_DEFAULTDECL_IN_ATTDEF)
   
   The full message displayed in VSCode may be different from elsewhere:
   
       White space is required before the attribute default in the declaration
       of attribute "x" for element "y". 
       xml(MSG_SPACE_REQUIRED_BEFORE_DEFAULTDECL_IN_ATTDEF)
   
   This simple one-line change appends the space character required to avoid that error.
   
   **Note:** This should not be modified into a change on the `joinAlts` Collector which surrounds
values in parentheses. That Collector is used elsewhere where regex syntax is applied immediately
after. See line 298. That asterisk cannot be separated from the values with a space. The space
must only be applied to line 327.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message