ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] jaikiran commented on a change in pull request #93: JUnit-5 tag functionality
Date Tue, 21 May 2019 14:26:47 GMT
jaikiran commented on a change in pull request #93: JUnit-5 tag functionality
URL: https://github.com/apache/ant/pull/93#discussion_r286054440
 
 

 ##########
 File path: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java
 ##########
 @@ -204,6 +215,8 @@ public Properties getProperties() {
         private boolean haltOnFailure;
         private List<TestDefinition> tests = new ArrayList<>();
         private List<ListenerDefinition> listeners = new ArrayList<>();
+		private List<String> includesList = new ArrayList<>();
 
 Review comment:
   Minor - can you name this `includeTags`. Same with the other one - `excludeTags`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message