ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on a change in pull request #90: solve the unconsistent comments
Date Mon, 08 Apr 2019 15:58:23 GMT
bodewig commented on a change in pull request #90: solve the unconsistent comments 
URL: https://github.com/apache/ant/pull/90#discussion_r273121101
 
 

 ##########
 File path: src/main/org/apache/tools/ant/types/selectors/modifiedselector/ModifiedSelector.java
 ##########
 @@ -686,9 +686,7 @@ public void addParam(Parameter parameter) {
 
 
     /**
-     * Defined in org.apache.tools.ant.types.Parameterizable.
-     * Overwrite implementation in superclass because only special
-     * parameters are valid.
+     * Set all the Parameters for this custom selector, collected by\n the ExtendSelector
class.
 
 Review comment:
   there seems to be something wrong with the new comment (literal `\n`) and I don't understand
what ExtendSelector refers to.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message