ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ant] bodewig commented on a change in pull request #90: solve the unconsistent comments
Date Mon, 08 Apr 2019 15:55:17 GMT
bodewig commented on a change in pull request #90: solve the unconsistent comments 
URL: https://github.com/apache/ant/pull/90#discussion_r273119651
 
 

 ##########
 File path: src/main/org/apache/tools/ant/ComponentHelper.java
 ##########
 @@ -452,12 +452,7 @@ public void checkTaskClass(final Class<?> taskClass) throws BuildException
{
     }
 
     /**
-     * Adds a new datatype definition.
-     * Attempting to override an existing definition with an
-     * equivalent one (i.e. with the same classname) results in
-     * a verbose log message. Attempting to override an existing definition
-     * with a different one results in a warning log message, but the
-     * definition is changed.
+     * Update the component definition table with a new or modified definition.
      *
 
 Review comment:
   This replaces a somewhat lengthy detailed description of what happens by a less clear one-liner.
Why is this better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message