ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] ant pull request #79: Make DataType and Reference generic
Date Mon, 12 Nov 2018 14:03:15 GMT
Github user bodewig commented on a diff in the pull request:

    https://github.com/apache/ant/pull/79#discussion_r232667496
  
    --- Diff: src/main/org/apache/tools/ant/types/ArchiveFileSet.java ---
    @@ -574,11 +570,8 @@ public int getDirMode() {
          * fileset if the project has been set).
          */
         private void checkArchiveAttributesAllowed() {
    -        if (getProject() == null
    -            || (isReference()
    -                && (getRefid().getReferencedObject(
    -                        getProject())
    -                    instanceof ArchiveFileSet))) {
    +        if (getProject() == null || (isReference()
    +                && getRefid().getReferencedObject(getProject()) instanceof ArchiveFileSet))
{
    --- End diff --
    
    please keep whitespace changes separate from PRs (or better just don't create them at
all)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message