From dev-return-91587-apmail-ant-dev-archive=ant.apache.org@ant.apache.org Sun Oct 28 17:48:44 2018 Return-Path: X-Original-To: apmail-ant-dev-archive@www.apache.org Delivered-To: apmail-ant-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA35C18E8B for ; Sun, 28 Oct 2018 17:48:44 +0000 (UTC) Received: (qmail 13672 invoked by uid 500); 28 Oct 2018 17:48:39 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 13599 invoked by uid 500); 28 Oct 2018 17:48:39 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 13587 invoked by uid 99); 28 Oct 2018 17:48:39 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 28 Oct 2018 17:48:39 +0000 Received: from v45346.1blu.de (v45346.1blu.de [178.254.23.72]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id A09FD205 for ; Sun, 28 Oct 2018 17:48:38 +0000 (UTC) Received: by v45346.1blu.de (Postfix, from userid 1000) id 473D44009C1; Sun, 28 Oct 2018 18:48:38 +0100 (CET) From: Stefan Bodewig To: dev@ant.apache.org Subject: Re: ant git commit: Add magic names for tests, run more tests in Surefire References: <16224a140b3c416eabe39a70ff326d22@git.apache.org> <87pnvuxb02.fsf@v45346.1blu.de> <87h8h6xa7d.fsf@v45346.1blu.de> Date: Sun, 28 Oct 2018 18:48:38 +0100 In-Reply-To: (Gintautas Grigelionis's message of "Sun, 28 Oct 2018 18:34:02 +0100") Message-ID: <87va5m55e1.fsf@v45346.1blu.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain On 2018-10-28, Gintautas Grigelionis wrote: > On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote: >> On 2018-10-28, Gintautas Grigelionis wrote: >>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote: >>>> I wonder whether it wouldn't be a good idea to create a separate class >>>> for constants used during testing that lives in ant-testutil rather than >>>> poluting the "magic names" of Ant. >>> The problem is that should such class end up in ant-testutil, it makes >> ant >>> dependent on ant-util and that creates a dependency loop. >> I'm talking about the "magic names" only used in tests. The four >> properties with names that start with TEST_ should not be used inside >> the rest of Ant, are they? > I understand your point. TEST_ properties are only for tests. But, the > tests themselves are a part of Ant core. Are they? I really hope there are no test classes in ant.jar. The constants can be moved to the tests jar of Ant core (where Ant core likely means org.apache.ant:ant in Maven speak) and ant-testutil. All Maven artifacts that are not org.apache.ant:ant can have a test scope dependency on ant-testutil. Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional commands, e-mail: dev-help@ant.apache.org