ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aprelev <...@git.apache.org>
Subject [GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...
Date Fri, 03 Aug 2018 21:47:56 GMT
Github user aprelev commented on a diff in the pull request:

    https://github.com/apache/ant-ivy/pull/73#discussion_r207675516
  
    --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java ---
    @@ -193,16 +193,8 @@ public void startElement(String uri, String localName, String qName,
                             String branch = attributes.getValue("branch");
                             String revision = attributes.getValue("revision");
                             Map<String, String> extraAttributes = new HashMap<>();
    --- End diff --
    
    It was, until I reused code for attributes extraction from `ExtendableItemHelper`. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message