ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aprelev <...@git.apache.org>
Subject [GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...
Date Wed, 01 Aug 2018 09:11:07 GMT
Github user aprelev commented on the issue:

    https://github.com/apache/ant-ivy/pull/73
  
    > Rather than hardcoding prefix, shouldn't we retrieve it by URL "http://ant.apache.org/ivy/extra"?
    
    Can you elaborate on prefix retrieving? The **extra-** prefix is [hardcoded at](https://github.com/apache/ant-ivy/blob/5918182e0d6836d89c42260da9de4428d4cbcec0/src/java/org/apache/ivy/plugins/report/XmlReportWriter.java#L175)
`XmlReportWriter::extraToString()` regardless of attribute namespace:
    ```Java
    sb.append(prefix).append("extra-").append(entry.getKey()).append("=\"")
        .append(XMLHelper.escape(entry.getValue())).append("\"");
    ```
    
    Maybe including namespace in XML report by passing *qualified* attributes to `XmlReportWriter::extraToString()`
would be a better choice then?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message