ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: FileUtils.normalize/isLeadingPath have bitten me
Date Mon, 02 Jul 2018 08:31:17 GMT
Hi Nicolas

many thanks for lending an extra pair of eyes. I'll add a few more
tests.

Stefan

On 2018-07-01, Nicolas Lalevée wrote:

> At my first read of the code I wondered if paths ending with slash are properly handled
in every case. After more careful reading, it is seems ok. Maybe some unit tests about it
would be nice, just to be sure.

> Then, about tackling the bug, I am on the same page as you both. It looks good to me.

> Nicolas

>> Le 1 juil. 2018 à 11:27, Stefan Bodewig <bodewig@apache.org> a écrit :

>> On 2018-06-28, Stefan Bodewig wrote:

>>> On 2018-06-28, Jaikiran Pai wrote:

>>>> Which then makes me wonder - in the context of this specific
>>>> untar/expand/unzip issue, should we probably be using a different
>>>> custom very specific logic (which relies on canonical files and
>>>> getParent()) instead of a call to isLeadingPath()?

>>> Probably. I used isLeadingPath because it has been already there - and )
>>> simply didn't realize it wouldn't do what I expected it to.

>> I decided to "fix" isLeadingPath for this edge case and add a method
>> using canonical paths instead - and use that in unzip and friends.

>> Please have a look at the proposed solution, I won't close the Bugzilla
>> issue before we have agreed this is the proper fix.

>> Cheers

>>        Stefan

>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org



> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message