ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: FileUtils.normalize/isLeadingPath have bitten me
Date Tue, 03 Jul 2018 07:46:36 GMT
On 2018-07-02, Stefan Bodewig wrote:

> On 2018-07-02, Jaikiran Pai wrote:

>> I just checked the commits related to this and it looks mostly
>> correct. However, I am still not 100% sure we have covered it all with
>> this new method that was introduced[1] and used in the unzip
>> part. What I mean is, the API expectations are right. However the
>> implementation _might_ need a bit of rethink since it still relies on
>> path string comparison (checks like endsWith) instead of a getParent()
>> check.

> I mostly kept the string comparison for performance reasons, but maybe
> that point is moot and performance should not be a concern
> here. Rewriting it to use getParent is no problem at all.

Done

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message