From dev-return-91081-apmail-ant-dev-archive=ant.apache.org@ant.apache.org Sun May 20 19:14:57 2018 Return-Path: X-Original-To: apmail-ant-dev-archive@www.apache.org Delivered-To: apmail-ant-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3C2818017 for ; Sun, 20 May 2018 19:14:57 +0000 (UTC) Received: (qmail 72818 invoked by uid 500); 20 May 2018 19:14:56 -0000 Delivered-To: apmail-ant-dev-archive@ant.apache.org Received: (qmail 72741 invoked by uid 500); 20 May 2018 19:14:56 -0000 Mailing-List: contact dev-help@ant.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Ant Developers List" Reply-To: "Ant Developers List" Delivered-To: mailing list dev@ant.apache.org Received: (qmail 72725 invoked by uid 99); 20 May 2018 19:14:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 May 2018 19:14:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A0BD8C0148 for ; Sun, 20 May 2018 19:14:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.879 X-Spam-Level: * X-Spam-Status: No, score=1.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 8fbVE2oJJXk8 for ; Sun, 20 May 2018 19:14:54 +0000 (UTC) Received: from mail-ot0-f180.google.com (mail-ot0-f180.google.com [74.125.82.180]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 4EADF5F356 for ; Sun, 20 May 2018 19:14:54 +0000 (UTC) Received: by mail-ot0-f180.google.com with SMTP id m11-v6so14596426otf.3 for ; Sun, 20 May 2018 12:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=aThywwWRqKmSWNpIe4jk+FUDBrI0YQzl0wCpgHbL9V0=; b=kU0Zl8+DpgLrSFwlyY3HOvF8Grtywwuo8Ke88vXt67Xax+4fP5XzLfErU79lws1nm7 GjIAO5OZN1xy++x6hdaOcSE8FktUS0NwBDf0ajp7iqCSv1WFGsHXI0s9Iz0vsJuBFlfW xNGA/wGU6BhKMUjJQiYaQGgb0klc1SKXCvYDmpvieP6ZEq79IdcyapfTLozKLl7utQ3L zV5GHQioSkugNizAHuCQzFlYyTJpn0UW/JwnkemYXJd06LCcTHPrbKoledeqrG8XrLLc F/1pFpBO1mp5O3Ogm4ruFmkdWH/+RWb2Xo1xCQwm/rNRSDFQkgpkOSEMiXGT65TVedUe mu8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=aThywwWRqKmSWNpIe4jk+FUDBrI0YQzl0wCpgHbL9V0=; b=YWdPfQfjHdHAaRc+iNJlbHZmqZ5asrv4axJ5bRF+/QBx+6BY25fc0uyvrd0gs/mhzT IhwvhFdBvPMwAUCJbeewsHH81jBmsnMmtMGm6IhVdT+VEZMdnDvZLuII0iyRIfISC1gR OL9/WXGiQRFimJDEVpz5cI6kgla9nGCCz87pexTJSw5WnuVOrPMiYmE1CIZhmTzrzZ3Y 5WoN+EEkZpGuSQ7o04Iltt5FjCfcroNVyLzPCw+r2D+dJ17tScVsAJfiqvqw3PhNokrg sc3FYV8Q2zOo3Em6GCy14qZW4nWhek8iBHTsG7FO5S0RfSzObk1r2Ig8OTGSHei4KQ6l Sa5Q== X-Gm-Message-State: ALKqPwdhbK9EN2KcmAGRe+9IlnoHDuMNe5aIsqN4veqnZAIzfKEKZICk +cQHcdkn93e6ZkHlmH4wf8m/cK/Li2746dGGVxI= X-Google-Smtp-Source: AB8JxZpgOfajgGv/8ltXn3Cw799cCLSH1esMVs9eyI34TGThB0MZZspc9rEhzKRfdw9h57PMiL+E0Bnkc3xDpwWjJxk= X-Received: by 2002:a9d:f48:: with SMTP id 66-v6mr12295347ott.146.1526843693509; Sun, 20 May 2018 12:14:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.209.45 with HTTP; Sun, 20 May 2018 12:14:53 -0700 (PDT) In-Reply-To: <87wovy8bau.fsf@v45346.1blu.de> References: <871se69qhd.fsf@v45346.1blu.de> <87wovy8bau.fsf@v45346.1blu.de> From: Gintautas Grigelionis Date: Sun, 20 May 2018 21:14:53 +0200 Message-ID: Subject: Re: dependeset-test failures To: Ant Developers List Content-Type: multipart/alternative; boundary="000000000000fab191056ca7ff70" --000000000000fab191056ca7ff70 Content-Type: text/plain; charset="UTF-8" 2018-05-20 19:52 GMT+02:00 Stefan Bodewig : > > Hi all > > > while running all tests locally I saw dependeset-test is failing, they > > are also failing on Jenkins. > > Found it > > https://github.com/apache/ant/commit/11422630936848e82c7b13a > b3fa68a3003e10195#diff-d84918760549fe4c0e195ba6cbfef4d3R268 > > this must be max() - the order of the original compare may have been > unexpected, I dont know. I've fixed it by now. > > May I use this as an additional hint that performing bulk changes that > nobody really reviews is a bad idea. In addition the test must have > failed everywhere where it was run. > Sorry, my bad, no failures occurred locally, but I saw failures at JetBrains and you've beaten me to it. Gintas --000000000000fab191056ca7ff70--