ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gintautas Grigelionis <g.grigelio...@gmail.com>
Subject Re: dependeset-test failures
Date Sun, 20 May 2018 19:14:53 GMT
2018-05-20 19:52 GMT+02:00 Stefan Bodewig <bodewig@apache.org>:

> > Hi all
>
> > while running all tests locally I saw dependeset-test is failing, they
> > are also failing on Jenkins.
>
> Found it
>
> https://github.com/apache/ant/commit/11422630936848e82c7b13a
> b3fa68a3003e10195#diff-d84918760549fe4c0e195ba6cbfef4d3R268
>
> this must be max() - the order of the original compare may have been
> unexpected, I dont know. I've fixed it by now.
>
> May I use this as an additional hint that performing bulk changes that
> nobody really reviews is a bad idea. In addition the test must have
> failed everywhere where it was run.
>

Sorry, my bad, no failures occurred locally, but I saw failures at
JetBrains and you've beaten me to it.

Gintas

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message