ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaikiran Pai <jai.forums2...@gmail.com>
Subject Re: [GitHub] ant pull request #:
Date Sun, 13 May 2018 10:54:35 GMT
No problem. That change to WHATSNEW is fine, I don't mind.

-Jaikiran


On 13/05/18 1:03 PM, Gintautas Grigelionis wrote:
> Thanks, great work! I hope you don't mind me taking the liberty to adjust
> WHATSNEW.
>
> Gintas
>
> 2018-05-13 6:01 GMT+02:00 Jaikiran Pai <jai.forums2013@gmail.com>:
>
>> I did plan to addit yesterday, but my local tests did not trigger the
>> package-info constant pool entry for some reason. So I decided to not rush
>> it in and spend some time to get the test right, to make sure it works
>> fine. I'll add it in either tonight or tomorrow once I get to see what's
>> going on.
>>
>> -Jaikiran
>>
>>
>>
>> On 12/05/18 9:19 PM, twogee wrote:
>>
>>> Github user twogee commented on the pull request:
>>>
>>>       https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b6
>>> 79705c2f2164426e7e6fb#commitcomment-28953469
>>>          In src/main/org/apache/tools/ant/taskdefs/optional/depend/const
>>> antpool/ConstantPoolEntry.java:
>>>       In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java
>>> on line 77:
>>>       Please add 20 (package), too
>>>
>>>
>>> ---
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message