ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaikiran Pai <jai.forums2...@gmail.com>
Subject Re: ant git commit: Inline buildfile names, make search easier
Date Mon, 30 Apr 2018 10:35:27 GMT

On 30/04/18 3:52 PM, Gintautas Grigelionis wrote:
> 2018-04-30 9:55 GMT+00:00 Stefan Bodewig <bodewig@apache.org>:
>
>> On 2018-04-30, Gintautas Grigelionis wrote:
>>
>>> My apologies for offending anyone; just one last silly question: why
>>> uniformity is not a requirement?
>> Who's uniformity do you pick? There are so many choices that only depend
>> on taste.
>>
>> assertEquals(x, y) vs assertThat(y, equalTo(x)) amd many many small
>> nuances that we all don't need to agree on, as long as we understand
>> what the code means and does and we accept to not change code just
>> because it doesn't conform to our own choices.
>>
> assertThat(object, matcher) is easier to parameterize, see MakeUrlTest.
> And regarding parameterization, I have found at least three cases of
> copy-paste errors
> where two supposedly different test cases were, in fact, identical.
>
The assertEquals vs assertThat was an example of different ways a 
certain thing can be implemented. I hope you do realize that what we are 
discussing in this thread (and others) is much more broader than finding 
copy/paste errors due to usage of one API over other.

-Jaikiran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message