ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: ant git commit: Yet more isEmpty()
Date Sun, 15 Apr 2018 10:04:29 GMT
On 2018-04-15, <gintas@apache.org> wrote:

> @@ -275,10 +270,7 @@ public class DefaultLogger implements BuildLogger {
>                      new BufferedReader(new StringReader(event.getMessage()))) {

>                      message.append(r.lines().map(line -> prefix + line)
> -                        .collect(Collectors.joining(StringUtils.LINE_SEP)));
> -                    if (message.length() == 0) {
> -                        message.append(prefix);
> -                    }
> +                        .collect(Collectors.joining(System.lineSeparator(), prefix,
"")));
>                  } catch (IOException e) {
>                      // shouldn't be possible
>                      message.append(label).append(event.getMessage());

I think this puts the last "prefix" in the wrong position, In the
original code it was appended after the message, the new joining call
puts it before the joined message. The second and third arg of joining
need to be swapped IMHO.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message