ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [2/4] ant git commit: Remove extraneous casts and (un)boxing, tersify logic
Date Fri, 06 Apr 2018 16:09:40 GMT
On 2018-04-01, <gintas@apache.org> wrote:

> http://git-wip-us.apache.org/repos/asf/ant/blob/95495d57/src/main/org/apache/tools/bzip2/BlockSort.java
> ----------------------------------------------------------------------
> diff --git a/src/main/org/apache/tools/bzip2/BlockSort.java b/src/main/org/apache/tools/bzip2/BlockSort.java

> @@ -651,7 +648,7 @@ class BlockSort {
>                          if (onceRun) {
>                              fmap[j] = a;
>                              if ((j -= h) <= mj) { //NOSONAR
> -                                break HAMMER;
> +                                break;
>                              }

Whoa. You are touching the scariest code inside of Ant :-)

Reviewing the break and continue changes will take some time.

Have you performed the changes with the help of some tools? Those loops
have been hand-optimized (by somebody who I hope understood the code
better than me) and I'm extremely reluctant to touching it at all.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message