ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] ant pull request #:
Date Sun, 22 Apr 2018 18:47:44 GMT
Github user bodewig commented on the pull request:

    https://github.com/apache/ant/commit/1e61ebdcad0aea45bb78627b231969f995a69f87#commitcomment-28688418
  
    In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java:
    In src/tests/junit/org/apache/tools/ant/AntClassLoaderTest.java on line 107:
    Aren't we missing the `fails` for the second and third call to `findClass` with `expectException`?
I may be wrong, but I think the rule will be satisfied if the first call throws an exception
and the test will happily pass even if the remaining calls don't.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message