ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] ant pull request #:
Date Thu, 05 Apr 2018 05:44:26 GMT
Github user bodewig commented on the pull request:

    https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28426843
  
    In src/main/org/apache/tools/ant/taskdefs/Sync.java:
    In src/main/org/apache/tools/ant/taskdefs/Sync.java on line 242:
    I think here and in the next hunk the classical loop was easier to read (in particular
given the comment above the loop :-) than the foreach version - and the `Arrays.sort` may
become expensive when the arrays are big.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message