ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Matèrne (jhm) <apa...@materne.de>
Subject AW: ant git commit: Inline buildfile names, make search easier
Date Mon, 30 Apr 2018 11:20:56 GMT
> > In my eyes most of the committers don't like these "code style"
> changes.
> > So please stop these changes and invest your energy more productive.
> >
> > I don't think it would be helpful if another committer starts
> > reverting the changes because of a different preference ...
> 
> 
> With all due respect, please let me know what do you prefer: for
> instance, is test parametrization good, bad or annoying?


For that single point I think parametrization is 'good'.
If I count right, it impacted three test classes.
Why change all the others?

Starting a discussion before such big changes would also be helpful.

Jan





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message