ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From BruceKuiLiu <...@git.apache.org>
Subject [GitHub] ant pull request #47: Add the "final" modifier to a public static field.
Date Sat, 14 Oct 2017 16:05:09 GMT
GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/ant/pull/47

    Add the "final" modifier to a public static field.

    This static field public but not final, and could be changed by malicious code or by accident
from another package. The field could be made final to avoid this vulnerability.
    http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/ant master4

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #47
    
----
commit ab72f9071269121d5b9fd7e38130a3ae4a8ed1a9
Author: Kui LIU <brucekuiliu@gmail.com>
Date:   2017-10-14T14:45:32Z

    Add the "final" modifier to a public static field.
    
    This static field public but not final, and could be changed by malicious code or by accident
from another package. The field could be made final to avoid this vulnerability.
    http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_FINAL

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message