ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bodewig <...@git.apache.org>
Subject [GitHub] ant issue #40: Add tests for parseLenientDateTime
Date Sat, 30 Sep 2017 04:50:54 GMT
Github user bodewig commented on the issue:

    https://github.com/apache/ant/pull/40
  
    Many thanks.
    
    I've fixed the line-ends to contain line-feeds only as I couldn't merge your patch on
a Linux box, therefore the PR now has conflicts. Sorry about that.
    
    As written the tests depend on the timezone of the machine  running the tests:
    
    ```
    Testcase: testLenientDateTime took 0,006 sec
    	FAILED
    expected:<1488622440000> but was:<1488618840000>
    junit.framework.AssertionFailedError: expected:<1488622440000> but was:<1488618840000>
    	at org.junit.Assert.fail(Assert.java:88)
    	at org.junit.Assert.failNotEquals(Assert.java:743)
    	at org.junit.Assert.assertEquals(Assert.java:118)
    	at org.junit.Assert.assertEquals(Assert.java:555)
    	at org.junit.Assert.assertEquals(Assert.java:542)
    	at org.apache.tools.ant.util.DateUtilsTest.testLenientDateTime(DateUtilsTest.java:119)
    ```
    
    this is on GMT+2 and off by an hour.  But as this is off by an hour I think it is more
about me being in daylight saving time right now while the date you picked was not (the EU
switches on the last weekends of March and October).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message