ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaikiran <...@git.apache.org>
Subject [GitHub] ant pull request #37: [1.9.x branch] BZ-60644 Fix file corruption during cop...
Date Thu, 28 Sep 2017 11:45:15 GMT
Github user jaikiran commented on a diff in the pull request:

    https://github.com/apache/ant/pull/37#discussion_r141594830
  
    --- Diff: src/main/org/apache/tools/ant/util/ResourceUtils.java ---
    @@ -666,6 +666,14 @@ private static void copyWithFilterSets(final Resource source, final
Resource des
                                                final String outputEncoding,
                                                final Project project)
             throws IOException {
    +        if (source instanceof FileResource && dest instanceof FileResource) {
    --- End diff --
    
    That makes sense. I have changed it to follow your suggestion and updated this PR. I am
going to run this against both windows on linux, through a Jenkins job, before merging this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message