ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jaikiran Pai <jai.forums2...@gmail.com>
Subject Re: Ivy - Move to symlink creation standard Java API?
Date Thu, 27 Jul 2017 14:08:24 GMT
Thank you for testing that kind of setup.

I have now pushed a commit which does the necessary changes to use Java 
standard API and also deprecates that use of symlinkmass option (which 
is no longer relevant) of the retrieve task. The testcases have been 
updated to make sure the tests are run on all systems (earlier they used 
to be run only on specific systems) and the logic in the tests has been 
updated to do a more robust check on ability to create symbolic links.

I have also updated the documentation and release notes to note and 
explain the deprecation of the symlinkmass option.

-Jaikiran


On 27/07/17 5:07 PM, Gintautas Grigelionis wrote:
> I did a few simple tests on Windows 7 + Cygwin and NIO.2 seems to work just
> fine (if privilege to create symlinks is granted).
>
> +1
>
> Gintas
>
> 2017-07-27 11:40 GMT+02:00 Gintautas Grigelionis <g.grigelionis@gmail.com>:
>
>> There might be some issues with Cygwin, see Eclipse/JGit discussion [1]
>>
>> Gintas
>>
>> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=354367
>>
>> 2017-07-27 10:44 GMT+02:00 Jan Matèrne (jhm) <apache@materne.de>:
>>
>>> If the new Java version supports the symlink creation and it's an
>>> implementation detail
>>> of Ivy (so not part of an API other could use) I am in favour of getting
>>> rid of the old
>>> implementation.
>>> Getting rid of that means being more standard compliant and having less
>>> to maintain. ;)
>>>
>>> Jan
>>>
>>>
>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: Nicolas Lalevée [mailto:nicolas.lalevee@hibnet.org]
>>>> Gesendet: Mittwoch, 26. Juli 2017 18:19
>>>> An: Ant Developers List
>>>> Betreff: Re: Ivy - Move to symlink creation standard Java API?
>>>>
>>>>
>>>>> Le 26 juil. 2017 à 15:25, Jaikiran Pai <jai.forums2013@gmail.com>
a
>>>> écrit :
>>>>> I was looking into a JIRA related to symlinking in Ivy and realized
>>>> that (for reasons noted in the docs and the implementation)
>>>> ourimplementation of symlinking relies on launching a process from
>>>> within the JVM to invoke a shell command to create the symlinks.
>>>> "retrieve" task is the only one that deals with symlink creation, from
>>>> what I can see. Furthermore, knowing that this operation is expensive,
>>>> we even had to introduce an additional optionfor that task to allow
>>>> "mass symlinking"[1] so that we launch a single process to create N
>>>> symlinks instead of N processes.
>>>>> In short, the current implementation of symlinking in Ivy is
>>>> expensive for reasons that have been known. Now that we have moved to
>>>> Java 7, which has a standard APIfor symlink creation[2], I think we
>>>> should just change our internal implementation to use this new standard
>>>> API.Of course, we continue to fail to create symlinks on systems that
>>>> don't support it, just like we do now, except that we let the Java API
>>>> implementation handle those details.
>>>>> Furthermore, once we move to thisstandard API, I don't think we need
>>>> the "symlinkmass" option onthe retrieve task anymore since the whole
>>>> purpose of it was to avoid launching N processes. So I think we can
>>>> deprecate that option in the upcoming release.
>>>>> Any thoughts?
>>>> Sounds good to me.
>>>>
>>>> Nicolas
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
>>>> commands, e-mail: dev-help@ant.apache.org
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>
>>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message