ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twogee <...@git.apache.org>
Subject [GitHub] ant-ivy pull request #52: Generics in core
Date Fri, 14 Jul 2017 15:16:23 GMT
Github user twogee commented on a diff in the pull request:

    https://github.com/apache/ant-ivy/pull/52#discussion_r127480601
  
    --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java ---
    @@ -306,7 +306,7 @@ public boolean isClosedRange() {
             return startVersion.equals(endVersion);
         }
     
    -    public boolean contains(String versionStr) throws ParseException {
    +    public boolean contains(String versionStr) {
    --- End diff --
    
    Not sure about this one, either: it's a consequence of previous changes to Version which
no longer throws exceptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message