ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwadamson <...@git.apache.org>
Subject [GitHub] ant issue #24: fix 60150 values containing backtick or $ character cause she...
Date Sat, 08 Oct 2016 14:28:25 GMT
Github user jwadamson commented on the issue:

    https://github.com/apache/ant/pull/24
  
    I hate dealing with arbitrary arguments. Those regex expressions still don't feel 100%
comfortable to me as to even why they seem to work. Trial and error is not a good way to figure
out patterns. Should have been able to do all the escaping on one line, but something didn't
like how I was adding backtick to the character class.
    
    So I'm not really sure my new form is functionally different, just trying to match more
closely how the reporter structured his change.
    
    Also my torture line seems to have been mangled a little in the comment, probably because
markup is doing interpreting as well. The "X" is supposed to be a backtick, but I can't get
markup to render correctly:
    
    `echo X "-Dfoo=dollar\$_backtick\X_single'_double\"_backslash\\"`
    `ant --execdebug run "-Dfoo=dollar\$_backtick\X_single'_double\"_backslash\\"`
    
    Also those echo's in the post were for debugging each transform, and I see you figured
that out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message