ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rm Beer <rmbe...@gmail.com>
Subject Re: [GitHub] ant pull request: JDK9 modules support for JUnitTask
Date Tue, 24 May 2016 01:55:13 GMT
sorry but not understand, i have privilege like developer for ant? i can
view all design and development.

2016-05-22 6:41 GMT-03:00 bodewig <git@git.apache.org>:

> Github user bodewig commented on the pull request:
>
>     https://github.com/apache/ant/pull/18#issuecomment-220823223
>
>     Thanks so much Tomáš and sorry for taking so long to get back to you.
>
>     I may be reading the code wrong, but do we end up with the modules
> being on the CLASSPATH as well as the module path if JUnit ist't part of
> the CLASSPATH? Can this do harm?
>
>     The code
>
>     ```java
>     return loader.getResource("junit.framework.Test") != null;
>     ```
>
>     looks curious to me. I recall applying a fix to Ant's scriptdef
> subsystem because we've been told you wouldn't be able to load classes as
> resources anymore (we used `ClassName.class` rather than `ClassName`,
> though) - has this changed?
>
>     And one nit, Ant has been bitten by locale sensitive bugs before,
> please use `Locale.ENGLISH` when using `toLowerCase`.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message