ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzezula <...@git.apache.org>
Subject [GitHub] ant pull request: JDK9 modules support for JUnitTask
Date Thu, 21 Apr 2016 20:30:45 GMT
GitHub user tzezula opened a pull request:

    https://github.com/apache/ant/pull/18

    JDK9 modules support for JUnitTask

    Changes:
    1.  Added modulepath and upgrademodulepath elements.
    2. When modulepath or upgrademodulepath is given VM fork is required.
    3. JUnit library required by Ant is searched both on classpath and modulepath.
    
    As seen in [JUnitTask + JDK9 question thread](http://mail-archives.apache.org/mod_mbox/ant-dev/201604.mbox/%3CAFE6C849-0622-44D1-9FF7-3A6CA4832F82%40oracle.com%3E)
there are many ways how to write and execute unit test in the JDK9 involving several java
options (`-addmods`, `-Xpatch`, `-XaddExports`, `-XaddReads`). 
    
    The JunitTask can 
    1. Keep the responsibility on user to correctly specify these options. The disadvantage
of these solution is the complexity of VM options.
    2. Automatically add the VM options. The disadvantage of these solution is that it’s
impossible to cover all scenarios and there needs to be a way how to disable it. Also the
options may change in time, for example if junit becomes a named module.
    
    Currently the patch contains the 1st. solution. 
    Thanks for comments!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzezula/ant jigsaw/junit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ant/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18
    
----
commit 2161a1383a3d09266351d70343f72a6398eb3a93
Author: Tomas Zezula <tomas.zezula@gmail.com>
Date:   2016-04-21T20:06:41Z

    JDK9 modules support for JUnitTask

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message