ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maarten Coene <maarten_co...@yahoo.com>
Subject Re: Ivy performance fix
Date Tue, 01 Apr 2014 19:36:26 GMT
Hi Josh,

yes I think we can merge this in the 2.4.0 final release, but we'll have to review a bit in
more detail first.
However, could you create a JIRA issue containing a link to the patch?

thanks!
Maarten



________________________________
 Van: Antoine Levy Lambert <antoine@gmx.de>
Aan: Ant Developers List <dev@ant.apache.org> 
Verzonden: dinsdag 1 april 3:58 2014
Onderwerp: Re: Ivy performance fix
 

Hello Josh,

thanks for contacting the Ant/Ivy community.

I think we can work with pull requests on github, as long as we see clearly the diffs with
the code in the svn repository we should be fine.

@Maarten, Nicolas, and others in the Ivy community, do you think we can merge this before
building the ivy 2.4.0 final ?

Regards,

Antoine

On Mar 31, 2014, at 4:15 PM, Josh Suereth <joshua.suereth@gmail.com> wrote:

> So, for the sbt project we noticed significant resolution time improvements
> with the following patch:
> 
> https://github.com/sbt/ivy/pull/1
> 
> The reasoning:
> 
> 
>   - A lot of artifacts being resolved use Maven's "dependencyManagement"
>   conventions
>   - Ivy appears to turn these into "exact matcher" rules
>   - A ton of resolution time is spent filtering through these rules
>   - The existing solution is O(n) for all overrides
> 
> 
> What the patch does:
> 
> 
>   - Creates a key'd store for all "exact matcher" rules
>   - When executing rules, ensure that we only traverse what we have to
>   (non-exact, exact specific to our key and "default").
> 
> 
> As I said, this represents a significant speed bump for sbt builds using
> Ivy.  All existing tests pass, and I think they cover this aspect of ivy
> pretty well, from what I could see.
> 
> What's the best mechanism to submit this back?  Do you accept pull requests
> on github?
> 
> Thanks!
> - Josh Suereth
>  Tools Lead
>   Typesafe, Inc.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message