ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antoine Levy Lambert <anto...@gmx.de>
Subject Re: [PATCH] Ivy useOrigin=true support for URLResolver with file:// URLs
Date Mon, 18 Nov 2013 00:08:21 GMT
Hello Charles,

thanks for proposing a patch.

I have read the patch and I see one area for improvement.

Your patch seems to assume that File URLs have exactly the same syntax like file system paths
except the file: prefix to indicate the protocol.

You need to use URLDecoder or equivalent because a File URL will have some special characters
encoded such as spaces replaced by %32.

 Regards,

Antoine

On Nov 11, 2013, at 1:51 PM, Charles Duffy wrote:

> This isn't actually so important for URLResolver itself, which can be replaced with the
FileSystem resolver at will -- but without this patch, one can't get the unique behavior of
the IBiblio resolver combined with useOrigin.
> 
> Feedback appreciated.
> <url-local-cache-support.diff>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message