ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peterrei...@apache.org
Subject svn commit: r477343 - in /ant/core/trunk/src/main/org/apache/tools: ant/taskdefs/Length.java ant/taskdefs/email/EmailTask.java ant/taskdefs/email/MimeMailer.java ant/taskdefs/optional/net/FTP.java mail/SmtpResponseReader.java
Date Mon, 20 Nov 2006 21:18:41 GMT
Author: peterreilly
Date: Mon Nov 20 13:18:41 2006
New Revision: 477343

URL: http://svn.apache.org/viewvc?view=rev&rev=477343
Log:
checkstyle

Modified:
    ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Length.java
    ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java
    ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
    ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java
    ant/core/trunk/src/main/org/apache/tools/mail/SmtpResponseReader.java

Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Length.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Length.java?view=diff&rev=477343&r1=477342&r2=477343
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Length.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/Length.java Mon Nov 20 13:18:41
2006
@@ -295,7 +295,7 @@
     }
 
     private class AllHandler extends Handler {
-        long accum = 0L;
+        private long accum = 0L;
         AllHandler(PrintStream ps) {
             super(ps);
         }

Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java?view=diff&rev=477343&r1=477342&r2=477343
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/EmailTask.java Mon Nov 20
13:18:41 2006
@@ -427,7 +427,7 @@
                 }
             }
             // SMTP auth only allowed with MIME mail
-            if (autoFound == false && ((user != null) || (password != null))
+            if (!autoFound && ((user != null) || (password != null))
                 && (encoding.equals(UU) || encoding.equals(PLAIN))) {
                 throw new BuildException("SMTP auth only possible with MIME mail");
             }

Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java?view=diff&rev=477343&r1=477342&r2=477343
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/email/MimeMailer.java Mon Nov 20
13:18:41 2006
@@ -58,7 +58,7 @@
  * @since Ant 1.5
  */
 public class MimeMailer extends Mailer {
-    private final static String SSL_FACTORY = "javax.net.ssl.SSLSocketFactory";
+    private static final String SSL_FACTORY = "javax.net.ssl.SSLSocketFactory";
 
     /** Default character set */
     private static final String DEFAULT_CHARSET

Modified: ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java?view=diff&rev=477343&r1=477342&r2=477343
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java Mon Nov 20
13:18:41 2006
@@ -2531,7 +2531,7 @@
         private static final String[] VALID_LANGUAGE_CODES =
             getValidLanguageCodes();
 
-        private static final String[] getValidLanguageCodes() {
+        private static String[] getValidLanguageCodes() {
             Collection c = FTPClientConfig.getSupportedLanguageCodes();
             String[] ret = new String[c.size() + 1];
             int i = 0;

Modified: ant/core/trunk/src/main/org/apache/tools/mail/SmtpResponseReader.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/mail/SmtpResponseReader.java?view=diff&rev=477343&r1=477342&r2=477343
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/mail/SmtpResponseReader.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/mail/SmtpResponseReader.java Mon Nov 20 13:18:41
2006
@@ -32,8 +32,9 @@
  *
  */
 public class SmtpResponseReader {
-
+    // CheckStyle:VisibilityModifier OFF - bc
     protected BufferedReader reader = null;
+    // CheckStyle:VisibilityModifier ON
     private StringBuffer result = new StringBuffer();
 
     /**



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message