ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Antoine Levy-Lambert <>
Subject AbstractFileSet/ bug 40722 [was : next release steps ]
Date Mon, 30 Oct 2006 02:14:41 GMT

the best solution would be to revert my changes in
AbstractFileSet#setupDirectoryScanner(FileScanner, Project),
and change this in mergePatterns :
        PatternSet ps = new PatternSet();
        ps.append(defaultPatterns, p);
       ps = defaultPatterns.clone();

the fact that PatternSet#append removes the include/exclude patterns
which are not valid due to if or unless clauses made us lose the
information that
there was an include pattern, leading to "<include if="property"> logic
changed for <javac> since ant 1.6.5"

at this occasion we should add a Clone() method to DataType and to

What do you think ?




Antoine Levy-Lambert wrote:
> Hi,
> I am pretty sure that Matt will rework my changes.
> AbstractFileset#mergePatterns is called from Sync#removeOrphans, so I
> could not remove it without changing sync.
> Regards,
> Antoine

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message