ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Loughran <ste...@apache.org>
Subject Re: svn commit: r413541 - /ant/core/trunk/src/main/org/apache/tools/ant/types/resources/PropertyResource.java
Date Mon, 12 Jun 2006 16:28:04 GMT
Matt Benson wrote:
> --- stevel@apache.org wrote:
> ant/core/trunk/src/main/org/apache/tools/ant/types/resources/PropertyResource.java
>> Sun Jun 11 15:00:52 2006
>> @@ -107,8 +107,7 @@
>>          if (isReference()) {
>>              return getCheckedRef().toString();
>>          }
>> -        return getName()!=null?("${"+getName()+"}")
>> -                :"null";
>> +        return String.valueOf(getValue());
>>      }
> 
> What if we make PropertyResource's toString()
> contingent on whether the property is set.  An unset
> property might evaluate to something like "${" +
> getName() + "} (unset)" and a set (immutable) property
> to getValue() ?
> 

that would be even cooler :)

there is also a toLongString() operation that I havent gone near yet; I 
was just tweaking the various resources so that toString() was 
meaningful in them.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message