ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject cvs commit: ant/src/main/org/apache/tools/ant/util DOMElementWriter.java
Date Mon, 14 Mar 2005 20:08:32 GMT
bodewig     2005/03/14 12:08:32

  Modified:    src/main/org/apache/tools/ant/util DOMElementWriter.java
  Log:
  Small refactoring to allow a less memory consuming "streaming mode"
  
  Revision  Changes    Path
  1.27      +55 -21    ant/src/main/org/apache/tools/ant/util/DOMElementWriter.java
  
  Index: DOMElementWriter.java
  ===================================================================
  RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/util/DOMElementWriter.java,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- DOMElementWriter.java	24 Jan 2005 18:13:20 -0000	1.26
  +++ DOMElementWriter.java	14 Mar 2005 20:08:32 -0000	1.27
  @@ -69,33 +69,15 @@
        * @param element the Root DOM element of the tree
        * @param out where to send the output
        * @param indent number of
  -     * @param indentWith string that should be used to indent the corresponding tag.
  +     * @param indentWith string that should be used to indent the
  +     * corresponding tag.
        * @throws IOException if an error happens while writing to the stream.
        */
       public void write(Element element, Writer out, int indent,
                         String indentWith)
           throws IOException {
   
  -        // Write indent characters
  -        for (int i = 0; i < indent; i++) {
  -            out.write(indentWith);
  -        }
  -
  -        // Write element
  -        out.write("<");
  -        out.write(element.getTagName());
  -
  -        // Write attributes
  -        NamedNodeMap attrs = element.getAttributes();
  -        for (int i = 0; i < attrs.getLength(); i++) {
  -            Attr attr = (Attr) attrs.item(i);
  -            out.write(" ");
  -            out.write(attr.getName());
  -            out.write("=\"");
  -            out.write(encode(attr.getValue()));
  -            out.write("\"");
  -        }
  -        out.write(">");
  +        openElement(element, out, indent, indentWith);
   
           // Write child elements and text
           boolean hasChildren = false;
  @@ -150,6 +132,58 @@
               }
           }
   
  +        closeElement(element, out, indent, indentWith, hasChildren);
  +    }
  +
  +    /**
  +     * Writes the opening tag - including all attributes -
  +     * correspondong to a DOM element.
  +     *
  +     * @param element the DOM element to write
  +     * @param out where to send the output
  +     * @param indent number of
  +     * @param indentWith string that should be used to indent the
  +     * corresponding tag.
  +     * @throws IOException if an error happens while writing to the stream.
  +     */
  +    public void openElement(Element element, Writer out, int indent,
  +                            String indentWith)
  +        throws IOException {
  +        // Write indent characters
  +        for (int i = 0; i < indent; i++) {
  +            out.write(indentWith);
  +        }
  +
  +        // Write element
  +        out.write("<");
  +        out.write(element.getTagName());
  +
  +        // Write attributes
  +        NamedNodeMap attrs = element.getAttributes();
  +        for (int i = 0; i < attrs.getLength(); i++) {
  +            Attr attr = (Attr) attrs.item(i);
  +            out.write(" ");
  +            out.write(attr.getName());
  +            out.write("=\"");
  +            out.write(encode(attr.getValue()));
  +            out.write("\"");
  +        }
  +        out.write(">");
  +    }
  +
  +    /**
  +     * Writes a DOM tree to a stream.
  +     *
  +     * @param element the Root DOM element of the tree
  +     * @param out where to send the output
  +     * @param indent number of
  +     * @param indentWith string that should be used to indent the
  +     * corresponding tag.
  +     * @throws IOException if an error happens while writing to the stream.
  +     */
  +    public void closeElement(Element element, Writer out, int indent,
  +                             String indentWith, boolean hasChildren)
  +        throws IOException {
           // If we had child elements, we need to indent before we close
           // the element, otherwise we're on the same line and don't need
           // to indent
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message