ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <>
Subject Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/metamata
Date Mon, 15 Nov 2004 15:33:21 GMT
On Mon, 15 Nov 2004, Dominique Devienne <> wrote:

> Stefan, could you explain the main categories of warning your
> changes are fixing?


but be fast ;-)

> I see a lot of local and member variables name changes, and I
> suspect some of them relate to name hiding,

almost all of them.  The one in extension/Specification even pointed
to a real bug.

> while some others kind of puzzle me. Why does Jikes care between
> newValue and newV?

| Local "newValue" shadows a field of the same name in
| "$Entry

> I guess I also picked up using static methods directly instead of
> thru an instance ref, but what else is there?


All of the fixes I committed have either been for shadowed defintions
or statics used as non-statics.  There also is a warning about switch
fall-throughs in JavaEnvUtils but they are wanted.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message