ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Reilly <peter.rei...@corvil.com>
Subject Re: cvs commit: ant/src/testcases/org/apache/tools/ant/filters ConcatFilterTest.java
Date Fri, 14 May 2004 12:56:46 GMT
Stefan Bodewig wrote:

>On 13 May 2004, <bodewig@apache.org> wrote:
>
>  
>
>>Make tests pass on MacOS X.
>>    
>>
>
>To recap the situation.
>
><fixcrlf> will use CR as line separator on any Mac, including on Macs
>that run MacOS X.  OS X obviously deals with all kinds of line
>separators but its native separator (including Java's line.separator
>system property) is a LF.
>
>The real solution probably would be to patch <fixcrlf> to base its
>decision on the line.separator property, but I'm really concerned
>about backwards compatibility since this behavior is part of <fixrclf>
>since Ant 1.1 and has been wrong since then as well - IIRC the first
>(pre-)releases of OS X have already been available in 2000.
>  
>
I think that it would be a good idea to use line.separator for the
default value.
It is less brittle than the current method, and I cannot imagine that
many people would have used <fixcrlf> on MacOSX without
setting the eol attribute.

Peter



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org


Mime
View raw message