ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From peter reilly <>
Subject Re: cvs commit: ant/src/testcases/org/apache/tools/ant/types/sele ctors
Date Mon, 15 Sep 2003 09:05:11 GMT

On Sunday 14 September 2003 02:20, Dominique Devienne wrote:
> Why so many files modified? I thought that after Peter's modif to Ant Core,
> as long as a selector is typedef'd, there's no need any more to hard code
> stuff in SelectorContainer and AbstractFileSet??? Or maybe I misunderstood
> something?
> The old hard-coding of selectors must remain for BackCompat, but any new
> selector would just magically work, as long as it implements FileSelector,
> right?

Not quite,
A new selector would need to be typedefed in
The problem is that the name "modified" (in this case) would
then be used up and could not be used for
example for a <modified> task, or (typedefed) condition/filter.

The solution to this namespace problem would
be to use roles.

I have (not synced up) code that adds a "role" attribute
to typedef which allows the context of the definition to
be limited to  add(Type x) and ant-type. This would have
the effect of allowing removing the hard-coding of the current selectors,
conditions, filters etc, placing the definitions in the antlib.xml for
However, I think it may be
better to wait for ant 1.7 to introduce another feature.


> Maybe I'm just off base though, so please enlighten me. Thanks, --DD
> -----Original Message-----
> From: []
> Sent: Saturday, September 13, 2003 11:36 AM
> To:
> Subject: cvs commit: ant/src/testcases/org/apache/tools/ant/types/selectors
> jhm         2003/09/13 09:35:52
>   Modified:    .        WHATSNEW
>                docs/manual/CoreTypes selectors-program.html selectors.html
>                src/etc/testcases/types selectors.xml
>                src/main/org/apache/tools/ant/taskdefs
>                src/main/org/apache/tools/ant/types
>                src/main/org/apache/tools/ant/types/selectors
>                src/testcases/org/apache/tools/ant/types/selectors
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> For additional commands, e-mail:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message