ant-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <>
Subject Re: New Laucher
Date Wed, 16 Jul 2003 08:46:55 GMT
On Tue, 15 Jul 2003, Jeff Tulley <> wrote:

> Shouldn't the last if statement instead be the following?:
>    if (!path.startsWith(File.separator)) {
>       sb.append("/");
>    }

Yes, I think so.

> I would also add some tests to

Thanks a lot.

> in fromURI, I think it is sufficient to look for a ":" anywhere in
> the filename, instead of just at the second position.

Sounds OK as File.pathSeparatorChar == ';' should exclude any
filesystem that would allow filenames with embeded colons, or so it

> Hopefully my attachments are in a format that won't be stripped by
> the mailing list, I can never remember what extension they need.


.txt seems to be fine.  AFAIK we only strip HTML (and I'd expect the
Content-Type header to be consulted, not the filename extension).

I'll take care of the patches.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message